Skip to content

Conversation

JustinTong0323
Copy link
Collaborator

Motivation

blocks by #11199

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Copy link
Contributor

Summary of Changes

Hello @JustinTong0323, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the 'tuning_fused_moe_triton' script to broaden its compatibility with various Mixture-of-Experts (MoE) model architectures, particularly focusing on Multimodal Large Language Models (MLLMs). It streamlines the process of extracting essential MoE configuration parameters from different model types, ensuring the tuning process can be applied to a wider range of models.

Highlights

  • Expanded MoE Model Support: The tuning script now includes support for 'Qwen3VLMoeForConditionalGeneration' and improves handling for encoder-decoder models by checking for 'text_config' to correctly extract MoE parameters.
  • Refactored Architecture Detection: The logic for identifying model architectures and extracting MoE-related parameters (number of experts, top-k, intermediate size) has been refactored for clarity and maintainability, introducing an 'architecture' variable to simplify conditional checks.
  • Temporary Parameter Exclusion: The 'per_channel_quant' parameter has been temporarily commented out in the 'save_configs' function, likely for debugging or a temporary disablement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants