-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[NVIDIA] Adding default args for DSR1 on Blackwell #11227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kushanam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the performance of DeepSeek V3 models on NVIDIA Blackwell architecture by automatically configuring optimal backend settings. It introduces default activations for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds default server arguments to optimize performance for DeepSeek V3 models on Blackwell GPUs. The changes correctly set the attention backend and enable FlashInfer all-reduce fusion. However, there is a critical issue with how FlashInfer TRTLLM MoE is enabled, as it uses a deprecated and non-existent attribute, which will cause a runtime error. My review includes a suggestion to fix this by using the current moe_runner_backend
argument.
if not self.enable_flashinfer_trtllm_moe: | ||
self.enable_flashinfer_trtllm_moe = True | ||
logger.info( | ||
f"Enable FlashInfer TRTLLM MoE on sm100 for {model_arch}" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code attempts to use self.enable_flashinfer_trtllm_moe
, which is not an attribute of the ServerArgs
class. This will cause an AttributeError
at runtime.
Additionally, the --enable-flashinfer-trtllm-moe
command-line argument is deprecated. The recommended way to enable this feature is by setting moe_runner_backend
to 'flashinfer_trtllm'
. The help message for the deprecated argument states: NOTE: --enable-flashinfer-trtllm-moe is deprecated. Please set --moe-runner-backend to 'flashinfer_trtllm' instead.
The suggested change fixes the error and uses the current recommended approach. It also checks if a user has already specified a moe_runner_backend
to avoid overriding their choice, which is consistent with how attention_backend
is handled.
if self.moe_runner_backend == "auto":
self.moe_runner_backend = "flashinfer_trtllm"
logger.info(
f"Set moe_runner_backend to 'flashinfer_trtllm' on sm100 for {model_arch}"
)
Optimized performance on Blackwell is achieved with these defaults:
--enable-flashinfer-allreduce-fusion
--attention-backend=trtllm_mla
--enable-flashinfer-trtllm-moe
This change sets those as the default behaviors.
Update server arguments to apply DSv3 default backends for attention, allreduce fusion, and MoE
N/A
N/A
Checklist