Github Actions separate to two jobs and staging #624
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,32 +1,94 @@ | ||||||||||||||||||||||||||||||||
| # Control Plane GitHub Action | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| name: Deploy to Control Plane Staging | ||||||||||||||||||||||||||||||||
| run-name: Deploy Control Plane Staging App | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # Controls when the workflow will run | ||||||||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||||||||
| push: | ||||||||||||||||||||||||||||||||
| branches: | ||||||||||||||||||||||||||||||||
| - 'main' | ||||||||||||||||||||||||||||||||
| - 'master' | ||||||||||||||||||||||||||||||||
| - ${{ github.vars.STAGING_APP_BRANCH }} | ||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
| branches: | |
| - 'main' | |
| - 'master' | |
| - ${{ github.vars.STAGING_APP_BRANCH }} | |
| branches: | |
| - 'main' | |
| - 'master' | |
| - ${{ vars.STAGING_APP_BRANCH }} |
🧰 Tools
🪛 actionlint (1.7.4)
12-12: character ' ' is invalid for branch and tag names. ref name cannot contain spaces, ~, ^, :, [, ?, *. see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
12-12: property "vars" is not defined in object type {action: string; action_path: string; action_ref: string; action_repository: string; action_status: string; actor: string; actor_id: string; api_url: string; base_ref: string; env: string; event: object; event_name: string; event_path: string; graphql_url: string; head_ref: string; job: string; job_workflow_sha: string; path: string; ref: string; ref_name: string; ref_protected: string; ref_type: string; repository: string; repository_id: string; repository_owner: string; repository_owner_id: string; repositoryurl: string; retention_days: number; run_attempt: string; run_id: string; run_number: string; secret_source: string; server_url: string; sha: string; token: string; triggering_actor: string; workflow: string; workflow_ref: string; workflow_sha: string; workspace: string}
(expression)
12-12: character ' ' is invalid for branch and tag names. ref name cannot contain spaces, ~, ^, :, [, ?, *. see man git-check-ref-format for more details. note that regular expression is unavailable. note: filter pattern syntax is explained at https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
(glob)
There was a problem hiding this comment.
Add missing required input for Build Docker Image action.
The action requires a PR_NUMBER input that is not provided.
Add the missing input:
- name: Build Docker Image
id: build
uses: ./.github/actions/build-docker-image
with:
app_name: ${{ env.APP_NAME }}
org: ${{ vars.CPLN_ORG_STAGING }}
commit: ${{ github.sha }}
+ PR_NUMBER: '' # Add appropriate value or make it optional in the action📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Build Docker Image | |
| id: build | |
| uses: ./.github/actions/build-docker-image | |
| with: | |
| app_name: ${{ env.APP_NAME }} | |
| org: ${{ vars.CPLN_ORG_STAGING }} | |
| commit: ${{ github.sha }} | |
| - name: Build Docker Image | |
| id: build | |
| uses: ./.github/actions/build-docker-image | |
| with: | |
| app_name: ${{ env.APP_NAME }} | |
| org: ${{ vars.CPLN_ORG_STAGING }} | |
| commit: ${{ github.sha }} | |
| PR_NUMBER: '' # Add appropriate value or make it optional in the action |
🧰 Tools
🪛 actionlint (1.7.4)
68-68: missing input "PR_NUMBER" which is required by action "Build Docker Image" defined at "./.github/actions/build-docker-image". all required inputs are "PR_NUMBER", "app_name", "commit", "org"
(action)
There was a problem hiding this comment.
Add missing required input for Deploy to Control Plane action.
The action requires a pr_number input that is not provided.
Add the missing input:
- name: Deploy to Control Plane
uses: ./.github/actions/deploy-to-control-plane
with:
app_name: ${{ vars.STAGING_APP_NAME }}
org: ${{ vars.CPLN_ORG_STAGING }}
github_token: ${{ secrets.GITHUB_TOKEN }}
wait_timeout: ${{ vars.WAIT_TIMEOUT || 900 }}
cpln_token: ${{ secrets.CPLN_TOKEN_STAGING }}
+ pr_number: '' # Add appropriate value or make it optional in the actionCommittable suggestion skipped: line range outside the PR's diff.
🧰 Tools
🪛 actionlint (1.7.4)
88-88: missing input "pr_number" which is required by action "Deploy to Control Plane" defined at "./.github/actions/deploy-to-control-plane". all required inputs are "app_name", "cpln_token", "github_token", "org", "pr_number"
(action)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix missing output value assignment.
The job declares
image_tagas an output but the value is never set in the build step. This could cause deployment failures.Ensure the build step sets the output:
- name: Build Docker Image id: build uses: ./.github/actions/build-docker-image with: app_name: ${{ env.APP_NAME }} org: ${{ vars.CPLN_ORG_STAGING }} commit: ${{ needs.process-deployment.outputs.pr_sha }} PR_NUMBER: ${{ needs.process-deployment.outputs.pr_number }} + # Add this step to set the output + - name: Set image tag output + if: success() + run: echo "image_tag=${{ env.APP_NAME }}:${{ needs.process-deployment.outputs.pr_sha }}" >> $GITHUB_OUTPUT📝 Committable suggestion
🧰 Tools
🪛 actionlint (1.7.4)
317-317: property "image_tag" is not defined in object type {}
(expression)