Conversation
These tests were for specific cases handled by private methods that have now been removed and therefore these tests should be removed.
From: https://github.com/shama/gaze/blob/master/lib/gaze.js#L260 it is possible that there would be no callback provided as described in https://github.com/shama/gaze/blob/master/lib/platform.js#L118 . I just added a case for when there is no callback provided. I needed this fix for a project of mine. Other wise great work Kyle Robinson Young :) This fix is for the following error ``` TypeError: undefined is not a function at Function.platform.close (/server/node/eve/node_modules/gaze/lib/platform.js:112:14) at Gaze._trigger (/server/node/eve/node_modules/gaze/lib/gaze.js:249:14) at Object.cb (/server/node/eve/node_modules/gaze/lib/platform.js:49:7) at /server/node/eve/node_modules/gaze/lib/statpoll.js:32:20 at iterate (/server/node/eve/node_modules/gaze/lib/helper.js:106:5) at /server/node/eve/node_modules/gaze/lib/helper.js:116:11 at /server/node/eve/node_modules/gaze/lib/statpoll.js:47:5 at iterate (/server/node/eve/node_modules/gaze/lib/helper.js:106:5) at /server/node/eve/node_modules/gaze/lib/helper.js:116:11 at /server/node/eve/node_modules/gaze/lib/statpoll.js:47:5 ```
undefined is not a function
Update downloads per month
upgrade definitions with latest nan
This reverts commit 199eaca.
add support for debouncing leading event
specifying the type and URL is deprecated: https://docs.npmjs.com/files/package.json#license http://npm1k.org/
update license attribute
|
it's pretty fast too.. so I ported watchify https://github.com/heavyk/gazeify |
heavyk
force-pushed
the
master
branch
2 times, most recently
from
32b6749 to
53219ae
Compare
|
shit, well it seems that the tests hang on linux for node-0.12 and iojs however, locally here on OSX and iojs it's all good |
|
Rad thanks for attempting this! Have you seen the navelgazer branch? In there I am consuming navelgazer as a dependency and it gets a bit further on the tests with linux. I believe only a couple are failing. |
|
oh, no, I didn't see the navalgazer branch. I'll check it out. this has been working for me flawlessly on OSX, so for now, I'm just going to leave it. later today I will be putting this up on the server. it'll get some linux testing then. cheers |
|
real quick: I read through some of your changes now. I had a similar issue when writing another thing. essentially, when pattern is lol, and I noticed that gaze04 was being used too for old node compat... ok, I think I can probably get this :) cheers mate |
13 participants
works with iojs
passes all tests