Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The audio player slider was percentage-based (max=100), meaning each tick represented 1% of track length rather than 1 second. On a 1-hour track, a single tick jumped 36 seconds.

Changes

  • Slider component: Changed max from 100 to track duration in seconds, value from percentage to currentTime
  • Player component: Renamed state from progress (percentage) to currentTime (seconds), updated end-of-track detection
  • Tests: Updated to use seconds-based assertions
// Before: percentage-based (jumpy)
<input type="range" max="100" value={progress} />

// After: seconds-based (1 tick = 1 second)  
<input type="range" max={duration} value={Math.floor(currentTime)} />

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.google.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/starpod/starpod/node_modules/.bin/../astro/astro.js check (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
starpod Ready Ready Preview, Comment Feb 4, 2026 4:20pm

Request Review

Copilot AI and others added 2 commits February 4, 2026 16:18
…onds

Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix audio player range input for smooth playback Fix jumpy audio player by setting slider max to track duration in seconds Feb 4, 2026
Copilot AI requested a review from argyleink February 4, 2026 16:19
@argyleink
Copy link
Collaborator

this does fix using arrow keys, they actually jump 1s at a time 👍🏻

@argyleink argyleink marked this pull request as ready for review February 4, 2026 16:23
@argyleink
Copy link
Collaborator

fixes #21

@RobbieTheWagner RobbieTheWagner merged commit 77bb2f2 into main Feb 5, 2026
5 checks passed
@RobbieTheWagner
Copy link
Member

@argyleink I don't think this fixes #21. The ship still gets cutoff toward the end, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants