Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR refactors cameras and camera consoles slightly. The "ss13" camera network is gone, and is now replaced with the "ship" camera network.
Mapped in camera consoles, and structural cameras will default to this ship network, prefixed with a pointer to the ship.

Example:
Mapped in body cameras are also supposed to default to the ship's network on init, but they don't do this, it seems. I can't quite figure out how to resolve this right now, but it looks like the mobile port is null during mapload, which causes the issue.
If a mapper wishes to change the network for a camera console, structural camera, or body camera, they can set the
mapload_networkvariable as they wish. For instance, an input of "banana" for the mapload_network variable will set the network as[ship_pointer]banana.Body camera initialization was changed slightly such that changing the name variable in a map will set the c_tag to this name. If one wishes to change the c_tag only, the name of the resulting body camera will be in the format "body camera - (
c_tag)".In addition, camera consoles and bodycameras can resync to a ship's camera network via their respective menus.
Why It's Good For The Game
I hadn't considered how mappers might use these devices in their maps, and I only recently realized that they're coded in such a way that they prevent certain usecases. This PR should hopefully address this and provide a bit more power for mappers to create the vision they want for their maps. If I miss anything with this refactor, feel free to let me know.
Changelog
🆑
add: ability to sync with ship's camera network, bodycam init on mapload
refactor: refactored camera backend to allow for mappers to set multiple custom networks for isolated camera networks within the same ship
/:cl: