Skip to content

Conversation

UnreachableCode
Copy link

@UnreachableCode UnreachableCode commented Mar 30, 2025

First time contributor checklist

Contributor checklist

  • Pixel 8, Android 15.
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

I think when the edit message feature was added, the ability to paste an image into the editing message was overlooked. Worth noting that this same bug also exists in the iOS application. I will not be fixing the iOS bug at this time.

For the fix, I've added the edit message ID into ConversationFragment.sendPreUploadMediaMessage(...) for the messageToEdit parameter. This is how it's done in the regular text send. I tested it with several messages in a chat and it now edits the existing message instead of sending a fresh one.

@UnreachableCode
Copy link
Author

UnreachableCode commented May 13, 2025

Hey @greyson-signal or @cody-signal, are you able to review this? I think the issue is now fixed on iOS.

@gabefair
Copy link

Thank you for making this change. Great fix

@UnreachableCode
Copy link
Author

You're welcome.

@gabefair
Copy link

gabefair commented Aug 2, 2025

Hi, this fork is a bit behind main, could you update your branch?

Copy link

stale bot commented Oct 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@UnreachableCode
Copy link
Author

Hi @gabefair - I rebased my fork on to the upstream, did a force push to my branch and it closed the PR for some reason. Is anybody able to re-open this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants