HYBIM-395 | Ensure metric attributes are present on errors #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrisa
approved these changes
Nov 4, 2025
zhirafovod
reviewed
Nov 4, 2025
|
|
||
| if isinstance(obj, EmbeddingInvocation): | ||
| invocation = obj | ||
| invocation = cast(Any, obj) |
There was a problem hiding this comment.
Asking to learn - why to case obj -> Any if it is an instance of EmbeddingInvocation?
There was a problem hiding this comment.
Mypy gets mad because invocation has been typed on line 67 as a LLMInvocation.
We know only one of these if statements would be entered, but mypy doesn't.
I suppose we could fix this to be a switch, or if elses. Or, use a different variable for each type as it comes through
There was a problem hiding this comment.
I've updated the variables to be unique. it just makes the PR noisy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples and ensured metrics have error.type when error is present