Fix CI test order - install util-genai before dependent packages #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for opentelemetry-util-genai-emitters-splunk fails with: ModuleNotFoundError: No module named 'opentelemetry.util.genai.emitters.spec' This happens because emitters-splunk depends on opentelemetry-util-genai being installed first (which contains the emitters.spec module). Reordered the test steps to install and test the base util-genai package before the packages that depend on it (emitters-splunk, evals, etc.).
Some tests have cross-dependencies between packages: - util-genai tests import from util-genai-evals - emitters-splunk tests import from util-genai Changed strategy to install all packages first (with --no-deps), then run each package's tests separately. This ensures all inter-package dependencies are available during testing.
Changed all 'logger' references to '_LOGGER' to match the module's logger variable name (line 239 and 245). This fixes the NameError that was occurring during test execution.
Tests were trying to mock 'handler._load_completion_callbacks' but the function is actually 'utils.load_completion_callbacks' (imported from utils module). Updated the mock patch paths to point to the correct location.
…ctories, update tests to match current implementation
…vals - Fix 4 instances of handler._load_completion_callbacks -> utils.load_completion_callbacks in test_evaluators.py - Fix test_evaluation_dynamic_aggregation.py to set _aggregate_results to None instead of False to enable dynamic environment variable reading as per actual implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for opentelemetry-util-genai-emitters-splunk fails with: ModuleNotFoundError: No module named 'opentelemetry.util.genai.emitters.spec'
This happens because emitters-splunk depends on opentelemetry-util-genai being installed first (which contains the emitters.spec module).
Reordered the test steps to install and test the base util-genai package before the packages that depend on it (emitters-splunk, evals, etc.).