Skip to content

Conversation

@JWinermaSplunk
Copy link
Contributor

@JWinermaSplunk JWinermaSplunk commented Nov 5, 2025

add gitlab releasing support for packages

@JWinermaSplunk JWinermaSplunk requested review from a team as code owners November 5, 2025 00:26
Copy link
Contributor

@johnbley johnbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some areas where the copy-paste-adjust pathway from splunk-otel-python went askew. Double check by grepping for key strings like splunk-opentelemetry and splunk-otel-python and adjusting those references as needed.
Overall looks like a good start though!

RELEASING.md Outdated

---

## Releasing splunk-opentelemetry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take another pass and be super sure that nothing attempts to release or document how to release something named splunk-opentelemetry - read back through these instructions and scope it just to releasing the genai work.

@zhirafovod
Copy link
Contributor

zhirafovod commented Nov 6, 2025

I think there are some areas where the copy-paste-adjust pathway from splunk-otel-python went askew. Double check by grepping for key strings like splunk-opentelemetry and splunk-otel-python and adjusting those references as needed. Overall looks like a good start though!

@JWinermaSplunk , we probably should remove the entire ./pyproject.toml file in the root folder, was copy pasted as @johnbley notied. But let's do it in a follow-up PR, as it is not included in ay PRs

# Used for local development, not to be published.
[project]
name = "splunk-opentelemetry-python-contrib"
...

Copy link
Contributor

@zhirafovod zhirafovod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @johnbley and @JWinermaSplunk !

@zhirafovod zhirafovod merged commit 30edd0f into signalfx:main Nov 6, 2025
1 of 14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants