-
Notifications
You must be signed in to change notification settings - Fork 2
Release scripts #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release scripts #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some areas where the copy-paste-adjust pathway from splunk-otel-python went askew. Double check by grepping for key strings like splunk-opentelemetry and splunk-otel-python and adjusting those references as needed.
Overall looks like a good start though!
RELEASING.md
Outdated
|
|
||
| --- | ||
|
|
||
| ## Releasing splunk-opentelemetry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take another pass and be super sure that nothing attempts to release or document how to release something named splunk-opentelemetry - read back through these instructions and scope it just to releasing the genai work.
@JWinermaSplunk , we probably should remove the entire ./pyproject.toml file in the root folder, was copy pasted as @johnbley notied. But let's do it in a follow-up PR, as it is not included in ay PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @johnbley and @JWinermaSplunk !
add gitlab releasing support for packages