feat: Traceloop evals #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityamehra
commented
Nov 6, 2025
| return True | ||
|
|
||
| # PRIORITY 2: Check for explicit LLM span kind (even without messages, for compatibility) | ||
| if span_kind == "llm": |
Contributor
Author
There was a problem hiding this comment.
limit to traceloop span kinds - https://www.traceloop.com/docs/openllmetry/contributing/semantic-conventions#llm-frameworks
adityamehra
commented
Nov 6, 2025
|
|
||
| # PRIORITY 3: Detect ReAct agent/task spans by kind | ||
| # These are agent workflows that contain LLM calls | ||
| if span_kind in ["agent", "task", "workflow"]: |
Contributor
Author
There was a problem hiding this comment.
Ideally, evals should be limited to llm spans
adityamehra
commented
Nov 6, 2025
| # ------------------------------------------------------------------ | ||
| # Internal helpers | ||
| # ------------------------------------------------------------------ | ||
| def _is_llm_span(self, span: ReadableSpan) -> bool: |
Contributor
Author
There was a problem hiding this comment.
Ideally, this method should return True for spans which are LLM calls or chat calls with the model
adityamehra
commented
Nov 6, 2025
| # Mapping from original span_id to translated INVOCATION (not span) for parent-child relationship preservation | ||
| self._original_to_translated_invocation: Dict[int, Any] = {} | ||
| # Buffer spans to process them in the correct order (parents before children) | ||
| self._span_buffer: List[ReadableSpan] = [] |
Contributor
Author
There was a problem hiding this comment.
Look into the span buffer logic
Contributor
Author
There was a problem hiding this comment.
Remove buffer logic if not required
adityamehra
commented
Nov 6, 2025
| # STEP 2: Check if this is an LLM span that needs evaluation | ||
| if self._is_llm_span(span): | ||
| _logger.debug( | ||
| "🔍 TRACELOOP PROCESSOR: LLM span '%s' detected! Processing immediately for evaluations", |
adityamehra
commented
Nov 6, 2025
| "Failed to stop LLM invocation: %s", stop_err | ||
| ) | ||
| else: | ||
| # Non-LLM spans (tasks, workflows, tools) - buffer for optional batch processing |
Contributor
Author
There was a problem hiding this comment.
Revisit this logic
91pavan
approved these changes
Nov 6, 2025
adityamehra
force-pushed
the
feature/single-tl-processor
branch
from
beb41f3 to
8c60348
Compare
adityamehra
force-pushed
the
feature/single-tl-processor
branch
from
3ca1998 to
fbad29e
Compare
wrisa
approved these changes
Nov 6, 2025
adityamehra
force-pushed
the
feature/single-tl-processor
branch
from
fbad29e to
b192589
Compare
verify commit
adityamehra
force-pushed
the
feature/single-tl-processor
branch
from
b192589 to
2579cbe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #29