Change release trigger to be release instead of the wrong tags
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Event to trigger workflow run is `push`, not `tags`. The `tags` part is just a filter. Signed-off-by: Mihai Maruseac <[email protected]>
Signed-off-by: Mihai Maruseac <[email protected]>
spencerschrock
approved these changes
Aug 27, 2024
mihaimaruseac
changed the title
release instead of the wrong tags
Sorry, forgot to do that. Updated now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Event to trigger workflow run is
push, nottags. Thetagspart is just a filter.But, we're copying
sigstore-pythonand usingreleasetrigger instead ofpush. This means that in order to trigger a release we have to create a new release in the repo, whereas withpushwe would need to dogit tag,git push --tags. They are equivalent in the end result, but for consistency withsigstore-pythonlet's use the same approach.Release Note
NONE
Documentation
NONE