cli: Adjust paths when signing and verifying in model_path '.' #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanberger
force-pushed
the
adjust_paths
branch
4 times, most recently
from
2266ee1 to
a3c5347
Compare
stefanberger
force-pushed
the
adjust_paths
branch
from
a3c5347 to
c978a79
Compare
When signing or verifying in model_path '.' then the model_path.name becomes an empty string and cannot be used for the name of the model in the Manifest. In this case, derive the name of the model from the model paths' absolute path and use the last directory's name. Use the same method for the model_path '..'. Extend a test case with signing while in the model directory and add a test case when signing while in a sub-directory of the model directory while using '.. for the model path. Resolves: sigstore#451 Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
adjust_paths
branch
from
c978a79 to
434bf61
Compare
mihaimaruseac
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust all paths when signing or verifying when the model_path is '.'. This is the case when signing while the current working directory is the model's directory.
Resolves: #451
Checklist