add max_workers experiment #479
                
     Merged
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Summary
This benchmarking experiment evaluates the effect of the max_workers count on sharded hashing. The worker counts were picked to fall around vCPU counts for common VMs.
Local experiments with a large model (to ignore the effects of OS disk caching) showed a diminishing effect beyond 8 workers, indicating the disk became the bottleneck. By default, we defer to the value selected by the
concurrent.futureslibrary (cpu_count + 4, up to a maximum of 32).We likely don't need to increase our value beyond the max of 32, but we may want to advocate for users to set the value lower if disk usage is a concern.
Checklist