Enable setting allow_symlinks on hashing Config and file serializers #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a set_allow_symlinks method to the hashing Config so that this option can be passed onto the file serializers. This method on the Config class seems necessary since its constructor does not have it. Signed-off-by: Stefan Berger <[email protected]>
src/model_signing/_cli.py
Outdated
Comment on lines
118
to
120
| # Decorator for the commonly used option to allow symlinks | ||
| _allow_symlinks_option = click.option( | ||
| "--allow-symlinks", |
There was a problem hiding this comment.
quick note that all the other flags are snake case, not kebab
There was a problem hiding this comment.
quick note that all the other flags are snake case, not kebab
Some exceptions do exist ... fixed.
--ignore-paths "../$(basename "${ignorefile}")"
stefanberger
force-pushed
the
allow_symlinks
branch
from
627771c to
535c286
Compare
mihaimaruseac
previously approved these changes
Jun 24, 2025
Add --allow_symlinks option to all signing and verifying methods. Signed-off-by: Stefan Berger <[email protected]>
Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
allow_symlinks
branch
from
535c286 to
bf099b8
Compare
mihaimaruseac
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a set_allow_symlinks method to the hashing Config so that this option can be passed onto the file serializers. This method on the Config class seems necessary since its constructor does not have it. Extend the CLI tool with a --allow-symlinks option on all signing and verifying methods and use this option in a scripted test case to test signing of files by following symlinks.
Summary
Checklist