Skip to content

Conversation

SequeI
Copy link
Contributor

@SequeI SequeI commented Jul 7, 2025

Summary

  • Fixed some tests for linter
  • Added more robust parsing for the bundle which was erroring out (Working off of main/sigstore-python)
  • Switched PublicKey to PublicKeyIdentifier
  • Added error handling + warning to old style verification material (tested verifying older signatures)
  • Verification material now checks with user provided public key in verifier
  • Updated changelog

Resolves #491

Checklist
  • All commits are signed-off, using DCO
  • All new code has docstrings and type annotations
  • All new code is covered by tests. Aim for at least 90% coverage. CI is configured to highlight lines not covered by tests.
  • Public facing changes are paired with documentation changes
  • Release note has been added to CHANGELOG.md if needed

@SequeI SequeI requested review from a team as code owners July 7, 2025 11:15
@mihaimaruseac
Copy link
Collaborator

Thank you! I'll run some testing and then press the merge button soon.

mihaimaruseac
mihaimaruseac previously approved these changes Jul 10, 2025
@mihaimaruseac mihaimaruseac enabled auto-merge (squash) July 10, 2025 16:31
@mihaimaruseac mihaimaruseac merged commit b8b4292 into sigstore:main Jul 10, 2025
51 checks passed
@SequeI SequeI deleted the publicKeyIdFix branch July 10, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VerificationMaterial Schema Mismatch: PublicKey Used Instead of PublicKeyIdentifier
3 participants