Skip to content

Conversation

hotcodemacha
Copy link
Contributor

Summary

Corrected Config.hash so ignored paths are joined with the model directory and validated not to escape it, ensuring ignore rules no longer depend on the current working directory

Preserved user-supplied relative paths in set_ignored_paths and added validation in add_ignored_paths for new entries, keeping all ignored paths relative to the model directory

Added a regression test to confirm that ignored files are skipped even when hashing from a different working directory

Checklist
  • All commits are signed-off, using DCO
  • All new code has docstrings and type annotations
  • All new code is covered by tests. Aim for at least 90% coverage. CI is configured to highlight lines not covered by tests.
  • Public facing changes are paired with documentation changes
  • Release note has been added to CHANGELOG.md if needed

Signed-off-by: Ashutosh Gupta <[email protected]>
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mihaimaruseac mihaimaruseac enabled auto-merge (squash) August 4, 2025 16:06
@mihaimaruseac mihaimaruseac merged commit e3a0481 into sigstore:main Aug 4, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants