Skip to content

Append index.html to directory urls. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sciurius wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Append index.html to directory urls. #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1421b2a
Append index.html to directory urls.
sciurius Aug 15, 2024
1963f85
Serve any of the conventional default documents in path, if it exists.
sciurius Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lib/get-file-path-from-url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const path = require('path');
const fs = require('fs');

/**
* Safely get the path for a file in the project directory, or reject by returning "dummy"
Expand Down Expand Up @@ -33,7 +34,21 @@ function getFilePathFromUrl(url, basePath, { pathLib = path, baseHref = '' } = {
}
}

const absolutePath = pathLib.join(basePath, relativePath);
let absolutePath = pathLib.join(basePath, relativePath);
if ( absolutePath.endsWith(pathLib.sep) ) {
// By convention, accessing a path routes to a default document in
// that directory if it exists.
// Commonly used default documents.
const defaultDocs = [ "index.html", "index.htm", "index.php" ];
// See if one of these exists.
for ( let d of defaultDocs ) {
if ( fs.existsSync( absolutePath + d ) ) {
absolutePath += d;
break;
}
}
}

if (
!absolutePath.startsWith(basePath) || // if the path has broken out of the basePath, it should be rejected
absolutePath.endsWith(pathLib.sep) // only files (not folders) can be served
Expand Down