Update dependency babel-plugin-ember-template-compilation to v3 #1292
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=80&v=4){kind=small}
|
| import n from 'eslint-plugin-n'; | ||
|
|
||
| import babelParser from '@babel/eslint-parser'; | ||
| import babelParser from '@babel/eslint-parser/experimental-worker'; |
There was a problem hiding this comment.
There was a problem hiding this comment.
I suppose we could wait for this worker to become stable before we upgrade the Ember plugin. I think it's fine to use this, seems to be working well.
There was a problem hiding this comment.
@wkillerud thanks for looking into this! only took notice of that now...
Here is an attempt of the same upgrade in the app blueprint: ember-cli/ember-app-blueprint#9. Apparently running into the same problems.
The CI log files are not available anymore. Were your fixes working for you?
If so, this needs a rebase and fixing some merge conflicts. If not, should we close this for now and wait for this to get figured out?
There was a problem hiding this comment.
I completely forgot about this 😅 I see there was a test failure, could be the screenshot tests. I'll rebase and try again.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
wkillerud
force-pushed
the
renovate/babel-plugin-ember-template-compilation-3.x
branch
from
85c2dd6 to
e657426
Compare
|
babel-plugin-ember-template-compilation@v3 is ESM, which is only supported in the experimental worker for babel/eslint-parser (for now). There was also a bug in older versions where an async config threw an error. Upgrading babel dependencies fixes that error.
wkillerud
force-pushed
the
renovate/babel-plugin-ember-template-compilation-3.x
branch
from
e657426 to
4ce3326
Compare
|
simonihmig
deleted the
renovate/babel-plugin-ember-template-compilation-3.x
branch
2 participants
This PR contains the following updates:
2.4.1->3.0.0Release Notes
emberjs/babel-plugin-ember-template-compilation (babel-plugin-ember-template-compilation)
v3.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.