Conversation
✅ Deploy Preview for simonmcmanus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR migrates storage from AWS S3 to Netlify Blobs, updates the codebase to ES modules (import/export), and removes Twitter integration.
Key Changes:
- Replaces AWS S3 storage with Netlify Blobs API using separate stores for JSON and images
- Converts all function files from CommonJS (require/exports) to ES modules (import/export)
- Updates response format from legacy Netlify function format to new Response API
- Removes Twitter integration (tweet.js deleted)
Reviewed changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds Netlify packages, retains aws-sdk dependency despite migration |
| netlify-json/fetch.sh | Adds shell script for fetching JSON from Netlify blobs (has line break issue) |
| __functions/url-summary.js | Converts to ES modules, updates response format, adds error handling for URL fetching |
| __functions/upload-image.js | Converts to ES modules, removes inline upload function (now imported from storage) |
| __functions/tweet.js | Removes Twitter integration entirely |
| __functions/tags.js | Converts to ES modules, updates response format |
| __functions/storage.js | Replaces AWS S3 implementation with Netlify Blobs API |
| __functions/netlify.js | Converts to ES modules, adds response return value |
| __functions/list-notes.js | Converts to ES modules, updates response format |
| __functions/list-links.js | Converts to ES modules, updates response format |
| __functions/deploy-succeeded.js | Converts to ES modules, adds response return value |
| __functions/cv-ai.js | Converts to ES modules, updates response format |
| __functions/build.js | Converts to ES modules, adds response return value |
| __functions/bluesky.js | Converts to ES modules, adds response return value |
| __functions/add-link.js | Converts to ES modules, updates response format, fixes imports |
Comments suppressed due to low confidence (1)
__functions/upload-image.js:12
- S3 client is initialized but never used. This should be removed as upload functionality now uses Netlify Blobs via the storage module.
const s3 = new AWS.S3({
accessKeyId: process.env.MY_AWS_ACCESS_KEY_ID,
secretAccessKey: process.env.MY_AWS_SECRET_ACCESS_KEY,
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@simonmcmanus I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@simonmcmanus I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.