Skip to content

Found a bug when pickr is destroyed before initialization is complete #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Found a bug when pickr is destroyed before initialization is complete #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d43f3
Found a bug when pickr is destroyed before EventLoop handle requestAn…
mardikarifqi Jul 23, 2020
683962a
Fixing lint
mardikarifqi Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/pickr.es5.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/pickr.es5.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/pickr.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/pickr.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 14 additions & 0 deletions src/js/pickr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ class Pickr {
_lastColor = HSVaColor();
_swatchColors = [];

// Destroy flag
_destroyed = false;

// Evenlistener name: [callbacks]
_eventListener = {
init: [],
Expand Down Expand Up @@ -143,6 +146,11 @@ class Pickr {
const that = this;
requestAnimationFrame((function cb() {

// If somehow Pickr DOM is deleted/destroyed before even rendered by browser, then stop
if (that._destroyed) {
return;
}

// TODO: Performance issue due to high call-rate?
if (!app.offsetWidth) {
return requestAnimationFrame(cb);
Expand Down Expand Up @@ -697,6 +705,9 @@ class Pickr {

Object.keys(this._components)
.forEach(key => this._components[key].destroy());

// Leaving _destroyed as a flag for TODO problem
this._destroyed = true;
}

/**
Expand All @@ -719,6 +730,9 @@ class Pickr {
// This cleans all of them to avoid detached DOMs
Object.keys(this)
.forEach(key => this[key] = null);

// Leaving _destroyed as a flag for TODO problem
this._destroyed = true;
}

/**
Expand Down