Skip to content

Updated to Socket.IO v1 api in case of active signalmaster's maxClients configuration #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated to Socket.IO v1 api in case of active signalmaster's maxClients configuration #57

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103cd23
Updated to Socket.IO v1 api in case of active signalmaster's maxClien…
scotu Jan 5, 2016
ccecaea
we want the number of keys in the room object to determine the number…
scotu Jan 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sockets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ module.exports = function (server, config) {
}

function clientsInRoom(name) {
return io.sockets.clients(name).length;
var room = io.sockets.adapter.rooms[name];
if (room && room.length) {
return room.length;
Copy link

@weinrank weinrank Jan 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for me:
room.length is always undefined.
You should use Object.keys(room).length instead of room.length

Otherwise clientsInRooms is always 0;

} else {
return 0;
}
}

};
Expand Down