[parse_effects] Implement parsing for subtype 87 and 269. #10786
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanthera
added a commit
to justindriggers/simc
that referenced
this pull request
Jan 20, 2026
renanthera
added a commit
that referenced
this pull request
Jan 20, 2026
…, Whirling Steel (#10764) * [Monk] Elixir of Determination, Predictive Training, Spirit of the Ox, Whirling Steel, Zen State * [Monk] Revert Zen State changes until the actual multiplier can be determined * [monk] use `parse_effects` for Predictive Training. Core support coming in #10786. * [monk] Correct Elixir of Determination and Whirling Steel proc behaviour. * [monk] Clarify what is going on with Elixir of Determination mystery action construction machine. --------- Co-authored-by: Kate Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.