Skip to content

Conversation

@palto42
Copy link
Collaborator

@palto42 palto42 commented Jul 4, 2025

As a next step for #84, this PR replaces the tool black with ruff. The maximum line length has been increased to 120.
The poetry lock file has been updated as well.

The files with modifications other than format changes are

  • README.md
  • poetry.lock
  • pyproject.toml
  • .devcontainer/Dockerfile
  • .devcontainer/devcontainer.json
  • .travis.yml
  • .vscode/settings.json

The actual soucre code and tests have not been modified except reformatting them with ruff.

@palto42 palto42 requested a review from andreasnuesslein July 4, 2025 13:40
@andreasnuesslein
Copy link
Member

@palto42 why did you increase the line length to 120? I mean, I know "why", but are the "new developments" in the best practices? I agree that 88 seems restrictive but at the same time, when i open split view for 4 columns of editor tabs, 88 is not bad.

@palto42
Copy link
Collaborator Author

palto42 commented Jul 6, 2025

@andreasnuesslein The reason why I suggest to increase the max line length is that it's meanwhile quite common to use 120 char limit. In my view it makes the code more readable with a bit less line breaks. cookiecutter-uv which I suggest to use as template for the target project layout uses 120 as default and also Pycharm defaults to 120. At the end it's maybe just personal preference.

If you prefer to stick with old length, I can change it back to 88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants