Skip to content

feat: update greeting format to include '@' for user mentions in templates #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

feat: update greeting format to include '@' for user mentions in templates #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion markdown-templates/readme/exercise-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<img src="https://octodex.github.com/images/Professortocat_v2.png" align="right" height="200px" />

Hey **{{ login }}**!
Hey @{{ login }}!

Mona here. I'm done preparing your exercise. Hope you enjoy! 💚

Expand Down
4 changes: 2 additions & 2 deletions markdown-templates/step-feedback/exercise-finished.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<img src="https://octodex.github.com/images/welcometocat.png" align="left" height="150px" />

Congratulations **{{ login }}**! You finished the exercise! 🎉🎉🎉
Congratulations @{{ login }}! You finished the exercise! 🎉🎉🎉

We've updated the repository with a couple changes to highlight your success!

Return to the [repository home](/{{ repo_full_name }}) page to see your progress!
Return to the [repository home](/{{ repo_full_name }}) page to see your progress!
2 changes: 1 addition & 1 deletion markdown-templates/step-feedback/welcome.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<img alt="original github octocat" src="https://octodex.github.com/images/original.png" align="left" height="80px" />

👋 Hey there {{ login }}! Welcome to your Skills exercise!
👋 Hey there @{{ login }}! Welcome to your Skills exercise!

{{ intro_message }}

Expand Down