-
Notifications
You must be signed in to change notification settings - Fork 20
feat: rename step-results template to step-results-table and simplify it
#29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2fbc044
feat: add step-results-table template
FidelusAleksander 0faf774
revert back to using name instead of check
FidelusAleksander 49468b5
Add alt text to images
chriswblake 56755cb
fix: update results table to use `description` instead of `name` vari…
FidelusAleksander 46bac43
chore: remove step-results template file
FidelusAleksander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| {{#passed}} | ||
|
|
||
| ## Step {{ step_number }} - Passed ✅ | ||
|
|
||
| {{/passed}} | ||
| {{^passed}} | ||
|
|
||
| ## Step {{ step_number }} - Fail ❌ | ||
|
|
||
| {{/passed}} | ||
|
|
||
| {{#passed}} | ||
| <img src="https://octodex.github.com/images/inflatocat.png" align="right" height="200px" alt="Inflatocat image indicating the step passed" /> | ||
| {{/passed}} | ||
| {{^passed}} | ||
| <img src="https://octodex.github.com/images/spidertocat.png" align="right" height="100px" alt="Spidertocat image indicating the step failed" /> | ||
| Some checks failed. Please review the results below and try again. | ||
|
|
||
| Time to find the bug! 🤔 | ||
| {{/passed}} | ||
|
|
||
| | Status | Name | | ||
| | --- | --- | | ||
| {{#results_table}} | ||
| | {{#passed}}✅ - Pass{{/passed}}{{^passed}}❌ - Fail{{/passed}} | {{ name }} | | ||
FidelusAleksander marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| {{/results_table}} | ||
|
|
||
| {{#tips.length}} | ||
|
|
||
| ### Tips | ||
|
|
||
| {{#tips}} | ||
|
|
||
| - {{.}} | ||
| {{/tips}} | ||
| {{/tips.length}} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.