feat: add update-readme-with-congratulations feature flag tofinish-exercise workflow
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a feature flag to control whether the README is updated during exercise start and finish workflows. The changes include:
- Adding a new boolean input "update-readme" to both workflows.
- Conditionally executing the "Update README" jobs based on the "update-readme" input.
- Updating quotes in the workflow YAML for consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/start-exercise.yml | Added the "update-readme" input and a conditional check for the "Update README" job. |
| .github/workflows/finish-exercise.yml | Added the "update-readme" input and a conditional check for the "Update README with congratulations" job. |
FidelusAleksander
changed the title
update-readme feature flags to start-exercise and finish-exercise workflows
…of an exercise, not the beginning.
chriswblake
changed the title
update-readme feature flags to start-exercise and finish-exercise workflowsupdate-readme-with-congratulations feature flag tofinish-exercise workflow
chriswblake
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The main objective of the workflows is to create/close the exercise issue. Updating the README is a feature that, we - in GitHub Skills will use (almost) in all exercises.
Checklist