fix: validate params_list length matches components in instantiate_pi…#169
Open
areychana wants to merge 1 commit intosktime:mainfrom
Open
fix: validate params_list length matches components in instantiate_pi…#169areychana wants to merge 1 commit intosktime:mainfrom
areychana wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
fixes #168
What does this implement/fix? Explain your changes.
instantiate_pipelinewas silently accepting aparams_listlonger thancomponentsthe extra param dicts got validated withcomp_name=Noneand passed to the executor without any error.So i added a length check in
src/sktime_mcp/tools/instantiate.pybefore the validation loop so that mismatched lengths return a clear error message instead of passing through silently.Does your contribution introduce a new dependency? If yes, which one?
no.
What should a reviewer concentrate their feedback on?
instantiate.pyaround line 195Any other comments?
This bug was originally flagged in issue #35. Raising a dedicated fix since it's a clear
validation gap, invalid input was passing through silently to the executor.
PR checklist