[BUG] fix: release orphaned data handle after auto-format in load_data_source#180
Open
KaranSinghDev wants to merge 1 commit intosktime:mainfrom
Open
[BUG] fix: release orphaned data handle after auto-format in load_data_source#180KaranSinghDev wants to merge 1 commit intosktime:mainfrom
KaranSinghDev wants to merge 1 commit intosktime:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When load_data_source runs with auto-format enabled (the default), it creates a raw data handle, then calls
format_data_handle()which creates a second formatted handle. Only the formatted handle is returned to the caller, but the raw intermediate handle was never deleted from _data_handles. This caused the internal dict to grow by 2 per call instead of 1, with no cap or eviction on data handles.Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
del self._data_handles[data_handle]lines, one in each code pathAny other comments?
I removed the original_handle from the sync response, it pointed to the deleted handle and would cause a "handle not found" error if used.
PR checklist
For all contributions
For new estimators