Initial submission #1
Conversation
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
comments for reviewers
| @@ -1,3 +1,3 @@ | |||
| [flake8] | |||
| max-line-length = 125 | |||
There was a problem hiding this comment.
For gen AI apps, this length is too small, thus I've changed it this time
| *.db | ||
| .pytype/ | ||
| .pytype/ | ||
| .idea/ |
There was a problem hiding this comment.
If we don't already have this in place in the main template, can we open a PR to update it?
There was a problem hiding this comment.
Here you are: slack-samples/bolt-python-starter-template#42
| app.event("assistant_thread_started")(start_thread_with_suggested_prompts) | ||
| app.event("assistant_thread_context_changed")(save_new_thread_context) | ||
| app.event("message", matchers=[is_user_message_event_in_assistant_thread])(respond_to_user_message) | ||
| app.event("message", matchers=[is_message_event_in_assistant_thread])(just_ack) |
There was a problem hiding this comment.
Other message events such as message_changed, message_deleted etc. are produced by an assistant thread's behavior. Just acknowledging them.
| app.event("message", matchers=[is_message_event_in_assistant_thread])(just_ack) | ||
|
|
||
|
|
||
| def is_message_event_in_assistant_thread(body: Dict[str, Any]) -> bool: |
There was a problem hiding this comment.
These is_xxx methods will be unnecessary once bolt-python's full support is released: slackapi/bolt-python#1162
| @@ -0,0 +1,62 @@ | |||
| from typing import Optional | |||
There was a problem hiding this comment.
This file will be unnecessary once bolt-python's full support is released: slackapi/bolt-python#1162
| "scopes": { | ||
| "bot": [ | ||
| "assistant:write", | ||
| "channels:join", |
There was a problem hiding this comment.
channels:join, channels:history, groups:history are optional and they are necessary only for the channel summarization prompt pattern
There was a problem hiding this comment.
LGTM! Thanks for putting this together so quickly. 🙇🏼♀️
Since this isn't a true template (contains functionality and not just dummy text), have suggested changes to reflect that and make it a sample. Will also change the repository name to bolt-python-app-assistant!
| *.db | ||
| .pytype/ | ||
| .pytype/ | ||
| .idea/ |
There was a problem hiding this comment.
If we don't already have this in place in the main template, can we open a PR to update it?
Co-authored-by: Alissa Renz <[email protected]>
|
It's all set! Before we make this repo public (perhaps early next week), we can merge this PR. |
Co-authored-by: Alissa Renz <[email protected]>
Type of change (place an x in the [ ] that applies)
Summary
Describe the goal of this PR. Mention any related Issue numbers.
If you are introducing a new sample app in this pull request, please also include a detailed description of the application’s purpose and functionality.
Requirements (place an x in each [ ] that applies)