-
Notifications
You must be signed in to change notification settings - Fork 416
Remove deprecated Steps from Apps feature #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2688 +/- ##
==========================================
- Coverage 93.40% 93.09% -0.32%
==========================================
Files 37 35 -2
Lines 7613 7080 -533
Branches 668 634 -34
==========================================
- Hits 7111 6591 -520
+ Misses 497 484 -13
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mwbrooks @haleychaas There are legacy docs that exist for this feature at |
Definitely @haleychaas call on how they want to handle the deprecation of docs 🤔 |
|
@misscoded Is there a way someone could still use it with an old version of Bolt? If so, I'd say we keep the docs and label them as legacy, but if not....I'm tempted to delete. |
|
@haleychaas Technically, no. Even if they were using it in an old version of Bolt, it wouldn't work, as the feature has been shut off. They'd get a deprecation warning and/or errors, and not be able to even see the feature, AFAIK. Usually I'd say we should keep it for posterity, but it gets dicey because SFA and the new version of steps are so similar – meaning it's possible that someone could happen upon this old stuff and think it's referring to the new stuff. A problem we shouldn't have, but one that we do, unfortunately. 🫠 So, I can see both arguments. If we want to remove it, just let me know - I leave that decision ultimately to the docs folks! |
|
@misscoded I say we delete it then! 🪓 |
518cbfe to
6afcc4e
Compare
Summary
Remove deprecated Steps from Apps feature, including related types, tests, and documentation.
Requirements (place an
xin each[ ])