feat: expose auto acknowledge for function handlers
#1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamBergamin
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 92.02% 92.09% +0.07%
==========================================
Files 195 195
Lines 6631 6631
==========================================
+ Hits 6102 6107 +5
+ Misses 529 524 -5 ☔ View full report in Codecov by Sentry. |
seratch
approved these changes
Oct 3, 2024
Contributor
seratch
left a comment
seratch
left a comment
There was a problem hiding this comment.
Looks good to me; Thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This PR exposes the
auto_acknowledgeflag at the at thefunctionlistener initialization level. This will allow the developer to build functions that callcompleteorfailbeforeack()(responding) the the slack request.This will be used for
dynamic optionssupportNOTE: the 3 second time out may prove to be a limitation since function have a timeout of 15 seconds, a follow up PR may be needed to imporve this behavior
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.