-
Notifications
You must be signed in to change notification settings - Fork 275
ci: post regression notifications if scheduled tests do not succeed #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1376 +/- ##
=======================================
Coverage 91.00% 91.00%
=======================================
Files 222 222
Lines 7512 7512
=======================================
Hits 6836 6836
Misses 676 676 ☔ View full report in Codecov by Sentry. |
mwbrooks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
|
@mwbrooks Kind appreciation in the iterations against regression - let's now merge this! 🤖 |
Summary
This PR follows #1374 and #1375 to send regression notifications if scheduled tests do not succeed instead of just during failures. Fixes an issue where test timeout did not post a message.
Testing
📺 Planning to add a few commits that confirm
!successis the correct operation for both "cancelled" and "failure" states. Since these steps run when scheduled on "main" outside of this PR, these are both events we want to capture I believe.Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.