Skip to content

Conversation

@szecket
Copy link
Contributor

@szecket szecket commented Sep 9, 2025

The color assignment for secondary (press) state for buttons and the button colors for dark mode and primary were a bit confused.
I have adjusted them according to OS observed and figma colors where I could find them

@ogoffart ogoffart changed the title live-preview: Cupertino button colors for Primary and secondary buttons Cupertino: button colors for Primary and secondary buttons Sep 10, 2025
@szecket szecket force-pushed the szecket/push-vxsskvlkoyyl branch from 0047c7c to 368a9e4 Compare September 10, 2025 16:21
Copy link
Member

@ogoffart ogoffart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the color of all controls in the cupertino style, is that expected and is that according to the official mac guidelines?

(Also patches like this are hard to read because of the formatting changes intermixed)

@szecket
Copy link
Contributor Author

szecket commented Sep 11, 2025

yes. and yes.
I changed one actual color - the accent color which was not the color on the mac.
I changed the assignment of some of the colors assigned to button and button primary background to match the spec from figma and where not available from the mac and sampling color from the ui. but I'll double check the implementation in gallery of the original pre-PR before pushing anything anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants