fix: voice assistant disconnects after greeting with no error shown (#878)

[chris-yyau]

Summary

Fixes the voice assistant silently disconnecting after "Hi, Happy here" with no feedback to the user. 4+ users reported this (#878).

• RealtimeVoiceSession.tsx + .web.tsx: Track wasConnected ref to distinguish initialization errors (silent — prevents startup "Terminals error") from post-connection errors (set status to 'error'). onDisconnect now preserves 'error' status instead of overwriting it.
• VoiceAssistantStatusBar.tsx: Error state shows "Voice disconnected — tap to dismiss" instead of being stuck. Tapping dismisses the bar.

Root cause

The onError handler silently set status to 'disconnected' for ALL errors, including runtime WebRTC failures after the greeting played. Then onDisconnect (which fires immediately after) would overwrite any error state. Users saw the UI return to idle with no explanation.

Note: This fix makes the disconnect visible but doesn't prevent it. The underlying disconnect is likely in the @elevenlabs/react-native SDK's WebRTC layer.

Addresses #878

Test plan

• Voice assistant greeting + listening works normally when connection is stable
• When connection drops after greeting, error bar appears with "Voice disconnected — tap to dismiss"
• Tapping the error bar dismisses it
• Startup initialization errors (no ElevenLabs) still degrade silently

🤖 Generated with Claude Code via Happy

[Copilot]

Pull request overview

This PR fixes a UX bug where the voice assistant could disconnect after the greeting without surfacing an error to the user, by distinguishing initialization-time failures (silent) from post-connection runtime failures (visible error state) and allowing the error banner to be dismissed.

Changes:

• Track a wasConnected ref in RealtimeVoiceSession (native + web) to show 'error' only for runtime failures after a successful connection.
• Update onDisconnect to avoid overwriting an existing 'error' status set by onError.
• Update the status bar error message and allow tapping to dismiss the error banner.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/happy-app/sources/realtime/RealtimeVoiceSession.tsx	Adds wasConnected tracking and preserves 'error' status across disconnects on native.
packages/happy-app/sources/realtime/RealtimeVoiceSession.web.tsx	Same runtime-vs-init error handling and status preservation for web.
packages/happy-app/sources/components/VoiceAssistantStatusBar.tsx	Changes error-state messaging and adds tap-to-dismiss behavior for the error banner.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

useSafeAreaInsets and Platform are imported but never used in this component. Please remove unused imports to keep the file clean and avoid future lint/typecheck tightening causing failures.

Suggested change

	import { View, Text, Pressable, StyleSheet, Platform } from 'react-native';
	import { useSafeAreaInsets } from 'react-native-safe-area-context';
	import { View, Text, Pressable, StyleSheet } from 'react-native';

[Copilot]

The error-state copy says “tap to dismiss”, but the full-width layout still renders the right-side hint as “Tap to end”. This results in conflicting instructions when realtimeStatus === 'error'. Update the UI copy/conditional rendering so the interaction hint matches the error behavior.

Suggested change

	text: 'Voice disconnected — tap to dismiss',
	text: 'Voice disconnected — tap to end',