Support for Zephir ZER and ZAR 9000, 12000, 18000 and 24000#1439
Open
geniodelmale wants to merge 3 commits intosmartHomeHub:masterfrom
Open
Support for Zephir ZER and ZAR 9000, 12000, 18000 and 24000#1439geniodelmale wants to merge 3 commits intosmartHomeHub:masterfrom
geniodelmale wants to merge 3 commits intosmartHomeHub:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Zephir mono-split remotes by introducing a new JSON configuration file that defines IR command strings for off, heat (with multiple intensity levels), and cool (with at least an auto mode and other variations).
- Adds a new JSON file “codes/climate/7000.json” that details supported models, temperature ranges, operation modes, fan modes, and base64 encoded IR commands for different operations.
Comments suppressed due to low confidence (1)
codes/climate/7000.json:1
- Adding inline documentation or a reference comment at the top of the file that explains the encoding scheme and source of these Base64 commands would help future maintainers understand and update the IR command values more confidently.
{
| "low", | ||
| "auto" | ||
| ], | ||
| "commands":{ |
There was a problem hiding this comment.
The file contains many long hardcoded base64 encoded command strings. To improve maintainability, consider extracting these commands into a separate file or generate them via a script with accompanying documentation so that future updates can be more easily managed.
Contributor
Author
|
I also fixed an error with heat auto for zephir 3380.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added basic support (only Cold, Heat, and Off) for Zephir mono-split remotes.