Draft
Conversation
RensR
commented
Feb 17, 2026
| /// @param newOwner The address to grant the DEFAULT_ADMIN_ROLE to, which can be used to transfer the CCIPAdmin role. | ||
| /// If address(0) is passed, the deployer will be used as the owner. This address will receive the preMinted tokens, | ||
| /// if any. | ||
| struct ConstructorParams { |
Collaborator
Author
There was a problem hiding this comment.
had to do this to avoid stack too deep in CCT Pool
kylesmartin
reviewed
Feb 17, 2026
RensR
force-pushed
the
Wrapped-pool
branch
3 times, most recently
from
9fa809c to
987b2f8
Compare
matYang
reviewed
Feb 24, 2026
matYang
reviewed
Feb 24, 2026
matYang
reviewed
Feb 24, 2026
matYang
reviewed
Feb 24, 2026
| address router | ||
| ) | ||
| BaseERC20(tokenParams) | ||
| TokenPool(IERC20(address(this)), tokenParams.decimals, advancedPoolHooks, rmnProxy, router) |
Collaborator
There was a problem hiding this comment.
hmm, address(token).code.length > 0 check happens inside TokenPool constructor, possible for it to be empty at constructor time? I thought that was the default behavior
Collaborator
Author
There was a problem hiding this comment.
It's still 0 at constructor time, this failed in all tests before this change
matYang
reviewed
Feb 24, 2026
matYang
reviewed
Feb 24, 2026
RensR
force-pushed
the
Wrapped-pool
branch
4 times, most recently
from
8ac77c0 to
7c0df5c
Compare
|
matYang
reviewed
Mar 13, 2026
| ConstructorParams memory args, | ||
| address burnMintRoleAdmin, | ||
| address owner | ||
| ) BaseERC20(args) AccessControlDefaultAdminRules(0, owner == address(0) ? msg.sender : owner) { |
Collaborator
There was a problem hiding this comment.
since this is for external use, I don't imagine most people have timelock, maybe by default we should set a non-zero delay, or accept as a constructor param, for AccessControlDefaultAdminRules?
matYang
reviewed
Mar 13, 2026
| function supportsInterface( | ||
| bytes4 interfaceId | ||
| ) public view virtual returns (bool) { | ||
| return interfaceId == type(IERC20).interfaceId || interfaceId == type(IGetCCIPAdmin).interfaceId; |
Collaborator
There was a problem hiding this comment.
nit: missing IERC165 interface check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new pool that's also a token. It also adds a new default token for CCIP, which is TokenPoolFactory compliant