Bundle LBTC and USDC updates with router migration#1834
Open
kylesmartin wants to merge 11 commits intodevelopfrom
Open
Bundle LBTC and USDC updates with router migration#1834kylesmartin wants to merge 11 commits intodevelopfrom
kylesmartin wants to merge 11 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bundles additional token-related updates into the EVM router migration flow (LBTC/Lombard + USDC) and makes Lombard chain configuration more flexible by allowing an explicit token pool ref, while also making on-ramp updates safer by not overwriting an existing on-ramp.
Changes:
- Add
RegisteredTokenPoolRefto Lombard chain configuration and plumb it through to the Lombard configure sequence to resolve the pool by an explicit datastore ref when provided. - Update
ConfigureChainForLanesto only set an OnRamp when none is currently set (avoid overwriting). - Extend the v1.2.0 EVM
RouterUpdaterto optionally (when relevant contracts exist) set LBTC’s pool inTokenAdminRegistryand update USDC lock/burn mechanisms; add tests for the new routing behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| deployment/v1_7_0/changesets/deploy_lombard_chains.go | Adds optional RegisteredTokenPoolRef to Lombard changeset config and passes it into configuration input. |
| deployment/v1_7_0/adapters/lombard.go | Extends Lombard configure input struct with RegisteredTokenPoolRef. |
| ccv/chains/evm/deployment/v1_7_0/sequences/lombard/configure_lombard_chain_for_lanes.go | Resolves Lombard token pool via explicit registered ref when provided, else falls back to qualifier-based lookup. |
| ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes.go | Avoids overwriting an existing on-ramp (safer router configuration). |
| chains/evm/deployment/v1_2_0/adapters/router.go | Bundles LBTC TAR SetPool + USDC mechanism updates into router updater when corresponding contracts are present. |
| chains/evm/deployment/v1_2_0/adapters/router_test.go | Adds coverage for router updater behavior with/without Lombard pool present in datastore. |
| ccv/chains/evm/deployment/latest/operations/lombard_token_pool/lombard_token_pool.go | Adds GetToken read operation for LombardTokenPool to support TAR SetPool wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ccv/chains/evm/deployment/v1_7_0/sequences/lombard/configure_lombard_chain_for_lanes.go
Outdated
Show resolved
Hide resolved
ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes.go
Outdated
Show resolved
Hide resolved
tt-cll
previously approved these changes
Mar 12, 2026
tt-cll
previously approved these changes
Mar 16, 2026
Collaborator
|
one of the tests is failing and looks legit: |
|
tt-cll
approved these changes
Mar 16, 2026
AnieeG
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus - skip onRamp update if an onRamp already exists, allow using a different registered pool for Lombard