Merged
Conversation
winder
approved these changes
Mar 17, 2026
Contributor
winder
left a comment
winder
left a comment
There was a problem hiding this comment.
Changes look good because GetS() and GetR() are safe to use with a nil receiver object.
0xAustinWang
requested review from
AmrMohamedRezk,
agusaldasoro,
asoliman92,
b-gopalswami,
makramkd,
ogtownsend and
tt-cll
tt-cll
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates protobuf field access to use generated getters for ECDSA signature R/S byte fields, improving safety when protobuf messages may be nil.
Changes:
- Replaced direct protobuf field reads (
.R/.S) with getters (GetR()/GetS()) when translating signatures. - Updated signature length validation to use getters, avoiding potential nil dereferences.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+76
to
78
| if len(pbSigs[i].GetR()) != 32 || len(pbSigs[i].GetS()) != 32 { | ||
| return nil, fmt.Errorf("signature must be 32 bytes: %v", pbSigs[i]) | ||
| } |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.