Conversation
…tion.AllowNilStreamValues aa
|
👋 brunotm, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
calvwang9
left a comment
There was a problem hiding this comment.
looks like we need to update the type in chainlink-common too
| if p.OptsCache.Len() != len(outcome.ChannelDefinitions) { | ||
| p.Logger.Warnw("OptsCache length mismatch with ChannelDefinitions length, resetting OptsCache", "optsCacheLen", p.OptsCache.Len(), "channelDefinitionsLen", len(outcome.ChannelDefinitions), "stage", "Outcome", "seqNr", outctx.SeqNr) | ||
| p.OptsCache.ResetTo(outcome.ChannelDefinitions) |
There was a problem hiding this comment.
given that we are introducing the ability to remove tombstoned channels, is relying on the len(outcome.ChannelDefinitions) still safe, i.e. if we add 1, remove 1 channel this wouldnt trigger a cache refresh right?
There was a problem hiding this comment.
any removal is handled in the same manner after the reset check which is only done to account for cold starts and b/g handovers
chainlink-data-streams/llo/plugin_outcome.go
Lines 107 to 114 in 1a0adb1
that pr was already merged. |
…amValues to enable compatible default behaviour
5337fa9 to
bdc028a
Compare
Uh oh!
There was an error while loading. Please reload this page.