Skip to content

feat: add CRE enabled flag domain configuration#861

Merged
ecPablo merged 2 commits intomainfrom
ecpablo/add-cre-cli-enabled-option
Mar 16, 2026
Merged

feat: add CRE enabled flag domain configuration#861
ecPablo merged 2 commits intomainfrom
ecpablo/add-cre-cli-enabled-option

Conversation

@ecPablo
Copy link
Contributor

@ecPablo ecPablo commented Mar 16, 2026

Adds a new config struct to the domain.yaml to allow users to opt in on the installation of the CRE CLI in their domain. I left it as a struct even if just has 1 fields to allow it to easily add new configs as we get more usage in the future. Using a pointer (*CRE) makes this a non-breaking change to prevent domains requiring to add this field.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: 445b256

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chainlink-deployments-framework Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ecPablo ecPablo marked this pull request as ready for review March 16, 2026 15:42
@ecPablo ecPablo requested a review from a team as a code owner March 16, 2026 15:42
Copilot AI review requested due to automatic review settings March 16, 2026 15:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new optional CRE configuration block to domain.yaml so domains can opt in (via an enabled flag) without breaking existing configs.

Changes:

  • Introduces a CRE config struct with an enabled flag.
  • Adds an optional cre field to each Environment in the domain config.
  • Adds a changeset bumping chainlink-deployments-framework minor for the new config surface.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
engine/cld/config/domain/domain.go Adds the new optional cre environment configuration type/field.
.changeset/nasty-needles-bathe.md Records a minor version bump for the new domain config fields.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment on lines 40 to 45
// Environment represents a single environment configuration.
type Environment struct {
NetworkTypes []string `mapstructure:"network_types" yaml:"network_types"`
Datastore DatastoreType `mapstructure:"datastore" yaml:"datastore"`
CRE *CRE `mapstructure:"cre" yaml:"cre,omitempty"`
}
@ecPablo ecPablo requested a review from bytesizedroll March 16, 2026 16:33
@cl-sonarqube-production
Copy link

@ecPablo ecPablo enabled auto-merge March 16, 2026 17:02
Copy link
Contributor

@bytesizedroll bytesizedroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecPablo ecPablo added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit ec0bb20 Mar 16, 2026
21 checks passed
@ecPablo ecPablo deleted the ecpablo/add-cre-cli-enabled-option branch March 16, 2026 17:16
github-merge-queue bot pushed a commit that referenced this pull request Mar 16, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## chainlink-deployments-framework@0.88.0

### Minor Changes

-
[#861](#861)
[`ec0bb20`](ec0bb20)
Thanks [@ecPablo](https://github.com/ecPablo)! - add CRE configuration
fields to domain config

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants