Skip to content

chore(framework): add log with solana's full entrypoint#2473

Open
gustavogama-cll wants to merge 1 commit intomainfrom
ggama/chore/log-solana-full-entrypoint
Open

chore(framework): add log with solana's full entrypoint#2473
gustavogama-cll wants to merge 1 commit intomainfrom
ggama/chore/log-solana-full-entrypoint

Conversation

@gustavogama-cll
Copy link
Contributor

@gustavogama-cll gustavogama-cll commented Mar 16, 2026

This should help debug flaky tests like DX-1824.


Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.

Why

The changes enhance the code readability and maintainability by extracting the entrypoint command construction into a separate variable with clear intent and logging the command before container creation. This makes the code easier to understand and debug.

What

  • framework/components/blockchain/solana.go
    • Extracted the logic for building the Solana container's entrypoint command into a separate variable. This simplifies the ContainerRequest by directly assigning the entrypoint variable.
    • Added a log statement to output the command used for creating the Solana container for easier debugging and visibility into the container startup process.

@gustavogama-cll gustavogama-cll requested a review from a team as a code owner March 16, 2026 21:11
Copilot AI review requested due to automatic review settings March 16, 2026 21:11
@gustavogama-cll gustavogama-cll marked this pull request as draft March 16, 2026 21:11
@github-actions
Copy link

👋 gustavogama-cll, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an informational log for the full Solana test-validator container entrypoint to aid debugging when bringing up the local Solana node via testcontainers.

Changes:

  • Factor the Solana container Entrypoint into a local entrypoint variable.
  • Log the computed entrypoint command before creating the container.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gustavogama-cll gustavogama-cll force-pushed the ggama/chore/log-solana-full-entrypoint branch from 628956a to a7a75de Compare March 16, 2026 21:16
@gustavogama-cll gustavogama-cll marked this pull request as ready for review March 16, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants