fix: trace tracking should stop when reaching CCIPReceive #644
Draft
vicentevieytes wants to merge 1 commit intomainfrom
Draft
fix: trace tracking should stop when reaching CCIPReceive #644vicentevieytes wants to merge 1 commit intomainfrom
vicentevieytes wants to merge 1 commit intomainfrom
Conversation
vicentevieytes
changed the title
vicentevieytes
changed the title
archseer
reviewed
Mar 17, 2026
| return true, (fmt.Errorf("failed to extract opcode from message in the trace: %w", err)) | ||
| } | ||
| //Stop tracing on CCIPReceive message delivery | ||
| if uint64(opcode) == offramp.OpcodeCCIPReceive { |
Collaborator
There was a problem hiding this comment.
Can we make this part of SubmitTransaction or determine somehow based on the input? Placing this straight into the txm makes this generic component CCIP 1.6 specific and will break on future versions/other products
Collaborator
There was a problem hiding this comment.
This would also require us to verify the contract address or we're vulnerable to spoofing if someone else deliberately uses this opcode downstream in the receiver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.