DF-22956: case normalization canary integration tests & rollout guide#4744
Open
cl-efornaciari wants to merge 3 commits intomainfrom
Open
DF-22956: case normalization canary integration tests & rollout guide#4744cl-efornaciari wants to merge 3 commits intomainfrom
cl-efornaciari wants to merge 3 commits intomainfrom
Conversation
…sset handling Adds tests verifying that mixed-case requests for the same asset pair (e.g. ETH vs Eth vs eth) resolve to the same cached response without causing WebSocket subscription churn. These tests require @chainlink/external-adapter-framework >= 2.14.0 with NORMALIZE_CASE_INPUTS support (DF-22956). Refs: DF-22956
Documents the phased rollout plan for DF-22956 NORMALIZE_CASE_INPUTS, including adapter batches, opt-out instructions for tiingo/tiingo-state, and optional cleanup of redundant requestTransforms. Refs: DF-22956
|
cl-efornaciari
changed the title
…t guide tiingoCommonSubscriptionRequestTransform was a factory function that returned a transform without executing it, making the toLowerCase() call a no-op. Replace with an empty stub for backward compatibility. Update rollout guide: full EA audit confirms no adapter needs NORMALIZE_CASE_INPUTS=false. Add tiingo/tiingo-state as high-priority rollout targets and document the broken transform bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blocksize-capitaladapter verifying that mixed-case requests forbase/quotepairs resolve to the same cached data when the framework-levelNORMALIZE_CASE_INPUTSsetting is enabled.tiingoCommonSubscriptionRequestTransformin bothtiingoandtiingo-state: the function was a factory that returned a transform without executing it, making thetoLowerCase()call a no-op since it was written. Replaced with empty stubs.CASE_NORMALIZATION_ROLLOUT.md) with full EA audit results confirming no adapter needsNORMALIZE_CASE_INPUTS=false— tiingo/tiingo-state are now high-priority rollout targets instead of opt-outs.Dependencies
Jira
DF-22956
EA Audit Summary
Full audit of all source adapters confirmed:
NORMALIZE_CASE_INPUTS=falseTest plan