Chore/use faust assignore if changelogtopics#18
Open
Mopsgeschwindigkeit wants to merge 2 commits intomasterfrom
Open
Chore/use faust assignore if changelogtopics#18Mopsgeschwindigkeit wants to merge 2 commits intomasterfrom
Mopsgeschwindigkeit wants to merge 2 commits intomasterfrom
Conversation
aiokafka 0.13.0 removed the `api_version` parameter from both `AIOKafkaConsumer` and `AIOKafkaProducer`. Since faust requires `aiokafka>=0.10.0`, it needs to handle both old and new versions. This adds a version check and conditionally includes `api_version` only when running with aiokafka < 0.13.0. Fixes faust-streaming#672
Mopsgeschwindigkeit
force-pushed
the
chore/use-faust-assignore-if-changelogtopics
branch
from
b987610 to
310b7ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
faust-assignorif app useschangelog_topics.Problems
If
self.app.conf.table_standby_replicas = 0theRoundRobinPartitionAssignoris used even is the app containschangelog_topics, which leads to a situation wherechangelog_topicsare not consumed at the start of the app.With newer version of aiokafka, some older api-version where deprecated.
Additional
This PR is based on the work of @nightcityblade (faust-streaming#674).