[BUGFIX] handle package name more gracefully #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary: Handle Package Name More Gracefully
Overview
This commit fixes a critical bug in field resolution where long package names caused incorrect message name extraction.
Changes Made
File:
protobuf_to_pydantic/gen_model.py
_get_field_info_dict_by_full_name()
to acceptpackage_name
parameterExample Scenario
Consider a protobuf file with:
Why Previous Implementation Was Buggy
The old code would split
analytics.dataplatform.user.UserProfile.user_id
into["analytics", "dataplatform", "user", "UserProfile", "user_id"]
and incorrectly extractdataplatform
as the message name (line 211:message_name, *key_list = split_full_name[1:]
). This caused field validation rules to be lost since the lookup would search fordataplatform.user_id
instead ofUserProfile.user_id
.Benefits