Fix: skip import generation for packages in ignore_pkg_list #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a field references a message from a package listed in ignore_pkg_list, skip generating relative imports to avoid importing non-existent p2p files. This allows ignore_pkg_list to work correctly for cross-package references while relying on customer_import_set for type resolution.
Add test proto files and test case to validate that packages in ignore_pkg_list do not generate import statements while still allowing type references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where packages listed in
ignore_pkg_listwere still generating import statements, causing compilation errors when the imported packages don't exist or shouldn't be imported.Problem
When using
ignore_pkg_listto exclude certain packages from code generation, the system would still attempt to generate import statements for cross-package references, leading to:Solution
Modified
FileDescriptorProtoToCode._add_other_module_pkgto check if a package is inignore_pkg_listbefore generating import statements. The fix allows type references to remain in the generated code while properly skipping the import generation.Changes
FileDescriptorProtoToCode._add_other_module_pkgto return early ifother_fd.packageis inself.config.ignore_pkg_list