refactor(ansible): split unarchive task & add download retries#397
Open
noelmcloughlin wants to merge 5 commits intosodafoundation:masterfrom
Open
refactor(ansible): split unarchive task & add download retries#397noelmcloughlin wants to merge 5 commits intosodafoundation:masterfrom
noelmcloughlin wants to merge 5 commits intosodafoundation:masterfrom
Conversation
noelmcloughlin
force-pushed
the
unarchive
branch
from
5b95245 to
5dca9f6
Compare
asifdxtreme
approved these changes
Mar 18, 2021
Member
asifdxtreme
left a comment
asifdxtreme
left a comment
There was a problem hiding this comment.
LGTM, please rebase the PR
noelmcloughlin
force-pushed
the
unarchive
branch
from
78a4e2c to
7434b18
Compare
noelmcloughlin
force-pushed
the
unarchive
branch
from
7434b18 to
e3217be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
If the download fails once it could be a network timeout.
If download retries fail then something else is wrong - so this PR helps detect that scenario.
Which issue(s) this PR fixes:
This PR is an optional improvement, not a bugfix
Test Report Added?:
Manually tested on Ubnut vagrant Virtualbox
Special notes for your reviewer:
Related to Troubleshooting #393