Merge branch 'main' into feat/wave-shaper

Author: maciejmakowski2003

CONTRIBIUTING.md

@@ -0,0 +1,25 @@
+# Contributing
+
+## Development
+
+To contribute by resolving already opened issues, please follow these steps:
+
+1. Fork the repository to your own GitHub account.
+2. Create a new branch for your feature or bug fix.
+3. Stage your changes and commit them. (Follow [Conventional Commit Specification](https://www.conventionalcommits.org/en/v1.0.0/))
+4. Submit PR for review.
+
+After your pull request is submitted, we will review it at as soon as possible.
+We may suggest changes or request additional improvements, so please enable
+[Allow edits from maintainers](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)
+on your PR.
+
+**Contribiuting by implementing your own feature should be preceeded by design doc. It can be any kind of document desciribing all important api and implementation details.**
+
+## Reporting Issues and Feature Requests
+
+If you encounter any bug, please report it [here](https://github.com/software-mansion/react-native-audio-api/issues/new?template=bug_report.yaml).
+
+For feature requests, please submit them [here](https://github.com/software-mansion/react-native-audio-api/issues/new?template=feature_request.yaml). You can also create a [discussion](https://github.com/software-mansion/react-native-audio-api/discussions) first to talk about your idea or join existing one.
+
+

apps/common-app/src/App.tsx

@@ -1,28 +1,23 @@
-import React from 'react';
-import type { FC } from 'react';
-import Animated from 'react-native-reanimated';
+import { NavigationContainer, useNavigation } from '@react-navigation/native';
 import { createStackNavigator } from '@react-navigation/stack';
+import type { FC } from 'react';
+import React from 'react';
 import {
   FlatList,
+  ListRenderItem,
+  Pressable,
   StyleSheet,
   Text,
-  Pressable,
-  ListRenderItem,
 } from 'react-native';
 import { GestureHandlerRootView } from 'react-native-gesture-handler';
-import { NavigationContainer, useNavigation } from '@react-navigation/native';
 
+import { Spacer } from './components';
 import Container from './components/Container';
 import { Example, Examples, MainStackProps } from './examples';
-import { layout, colors } from './styles';
-import { Spacer } from './components';
+import { colors, layout } from './styles';
 
 const Stack = createStackNavigator();
 
-// Our slider component uses the text prop to display shared value
-// We need it whitelisted in order to have it "animated".
-Animated.addWhitelistedNativeProps({ text: true });
-
 const ItemSeparatorComponent = () => <Spacer.Vertical size={16} />;
 
 const HomeScreen: FC = () => {
@@ -35,7 +30,8 @@ const HomeScreen: FC = () => {
       style={({ pressed }) => [
         styles.button,
         { borderStyle: pressed ? 'solid' : 'dashed' },
-      ]}>
+      ]}
+    >
       <Text style={styles.title}>{item.title}</Text>
       <Text style={styles.subtitle}>{item.subtitle}</Text>
     </Pressable>
@@ -68,7 +64,8 @@ const App: FC = () => {
             headerTintColor: colors.white,
             headerBackTitle: ' ',
             headerBackAccessibilityLabel: 'Go back',
-          }}>
+          }}
+        >
           <Stack.Screen
             name="Home"
             component={HomeScreen}

apps/fabric-example/ios/Podfile.lock

@@ -2675,7 +2675,7 @@ PODS:
     - RNWorklets
     - SocketRocket
     - Yoga
-  - RNScreens (4.17.1):
+  - RNScreens (4.18.0):
     - boost
     - DoubleConversion
     - fast_float
@@ -2702,10 +2702,10 @@ PODS:
     - ReactCodegen
     - ReactCommon/turbomodule/bridging
     - ReactCommon/turbomodule/core
-    - RNScreens/common (= 4.17.1)
+    - RNScreens/common (= 4.18.0)
     - SocketRocket
     - Yoga
-  - RNScreens/common (4.17.1):
+  - RNScreens/common (4.18.0):
     - boost
     - DoubleConversion
     - fast_float
@@ -3219,7 +3219,7 @@ SPEC CHECKSUMS:
   RNAudioAPI: c763dbacdb8d89b7ce829484306df54322a7d951
   RNGestureHandler: f1dd7f92a0faa2868a919ab53bb9d66eb4ebfcf5
   RNReanimated: e4993dd98196c698cbacc1441a4ac5b855ae56dc
-  RNScreens: 833237c48c756d40764540246a501b47dadb2cac
+  RNScreens: d821082c6dd1cb397cc0c98b026eeafaa68be479
   RNSVG: 8c0bbfa480a24b24468f1c76bd852a4aac3178e6
   RNWorklets: d4553da98908962b6b834d5f2d26525b0d6840ad
   SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748

packages/audiodocs/docs/fundamentals/getting-started.mdx

@@ -119,6 +119,13 @@ const config = {
 module.exports = wrapWithAudioAPIMetroConfig(config);
 ```
 
+### Step 4: Install system-wide bash (only Windows OS)
+
+There are many ways to do that f.e. using git bash. To make sure just test if any unix command works.
+```bash
+bash -c 'echo Hello World!'
+```
+
 ### Possible additional dependencies
 
 If you plan to use any of [`WorkletNode`](/docs/worklets/worklet-node), [`WorkletSourceNode`](/docs/worklets/worklet-source-node), [`WorkletProcessingNode`](/docs/worklets/worklet-processing-node), it is required to have

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.cpp

@@ -50,7 +50,6 @@ void AudioAPIModule::registerNatives() {
       makeNativeMethod(
           "invokeHandlerWithEventNameAndEventBody",
           AudioAPIModule::invokeHandlerWithEventNameAndEventBody),
-      makeNativeMethod("closeAllContexts", AudioAPIModule::closeAllContexts),
   });
 }
 
@@ -96,8 +95,4 @@ void AudioAPIModule::invokeHandlerWithEventNameAndEventBody(
     audioEventHandlerRegistry_->invokeHandlerWithEventBody(eventName->toStdString(), body);
   }
 }
-
-void AudioAPIModule::closeAllContexts() {
-  AudioAPIModuleInstaller::closeAllContexts();
-}
 } // namespace audioapi

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/AudioAPIModule.h

@@ -34,7 +34,6 @@ class AudioAPIModule : public jni::HybridClass<AudioAPIModule> {
 
   void injectJSIBindings();
   void invokeHandlerWithEventNameAndEventBody(jni::alias_ref<jni::JString> eventName, jni::alias_ref<jni::JMap<jstring, jobject>> eventBody);
-  void closeAllContexts();
 
  private:
   friend HybridBase;

packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/AudioAPIModule.kt

@@ -40,8 +40,6 @@ class AudioAPIModule(
     eventBody: Map<String, Any>,
   )
 
-  private external fun closeAllContexts()
-
   init {
     try {
       System.loadLibrary("react-native-audio-api")
@@ -77,15 +75,14 @@ class AudioAPIModule(
   }
 
   override fun onHostDestroy() {
-    closeAllContexts()
+    // do nothing
   }
 
   override fun initialize() {
     reactContext.get()?.addLifecycleEventListener(this)
   }
 
   override fun invalidate() {
-    closeAllContexts()
     reactContext.get()?.removeLifecycleEventListener(this)
     // think about cleaning up resources, singletons etc.
   }

packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/AudioFocusListener.kt

@@ -28,6 +28,7 @@ class AudioFocusListener(
           }
         audioAPIModule.get()?.invokeHandlerWithEventNameAndEventBody("interruption", body)
       }
+
       AudioManager.AUDIOFOCUS_LOSS_TRANSIENT -> {
         playOnAudioFocus = lockScreenManager.get()?.isPlaying == true
         val body =
@@ -37,6 +38,7 @@ class AudioFocusListener(
           }
         audioAPIModule.get()?.invokeHandlerWithEventNameAndEventBody("interruption", body)
       }
+
       AudioManager.AUDIOFOCUS_GAIN -> {
         if (playOnAudioFocus) {
           val body =

packages/react-native-audio-api/android/src/main/java/com/swmansion/audioapi/system/LockScreenManager.kt

@@ -155,6 +155,7 @@ class LockScreenManager(
         "state_playing" -> {
           this.playbackState = PlaybackStateCompat.STATE_PLAYING
         }
+
         "state_paused" -> {
           this.playbackState = PlaybackStateCompat.STATE_PAUSED
         }

packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h

@@ -23,9 +23,6 @@ namespace audioapi {
 using namespace facebook;
 
 class AudioAPIModuleInstaller {
- private:
-  inline static std::vector<std::weak_ptr<AudioContext>> contexts_ = {};
-
  public:
   static void injectJSIBindings(
       jsi::Runtime *jsiRuntime,
@@ -56,19 +53,6 @@ class AudioAPIModuleInstaller {
         jsi::Object::createFromHostObject(*jsiRuntime, audioEventHandlerRegistryHostObject));
   }
 
-  static void closeAllContexts() {
-    for (auto it = contexts_.begin(); it != contexts_.end(); ++it) {
-      auto weakContext = *it;
-
-      if (auto context = weakContext.lock()) {
-        context->close();
-      }
-
-      it = contexts_.erase(it);
-      --it;
-    }
-  }
-
  private:
   static jsi::Function getCreateAudioContextFunction(
       jsi::Runtime *jsiRuntime,
@@ -97,7 +81,6 @@ class AudioAPIModuleInstaller {
 
           audioContext = std::make_shared<AudioContext>(
               sampleRate, audioEventHandlerRegistry, runtimeRegistry);
-          AudioAPIModuleInstaller::contexts_.push_back(audioContext);
 
           auto audioContextHostObject =
               std::make_shared<AudioContextHostObject>(audioContext, &runtime, jsCallInvoker);