feat: support for midi 0.1 #736

poneciak57 · 2025-10-13T04:47:48Z

Under construction
Closes #

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

packages/react-native-medi/package.json

maciejmakowski2003 · 2025-12-02T13:16:34Z

packages/react-native-medi/src/NativeMedi.web.ts

+} from './types';
+
+// Web MIDI API types
+interface WebMIDIPort {


duplicated MIDIPortInfo

maciejmakowski2003 · 2025-12-02T13:18:08Z

packages/react-native-medi/src/specs/NativeMedi.ts

+import type { CodegenTypes, TurboModule } from 'react-native';
+import { TurboModuleRegistry } from 'react-native';
+
+export interface MIDIPortInfoCodegen {


duplicated MIDIPortInfo

packages/react-native-medi/src/index.ts

packages/react-native-medi/src/index.web.ts

packages/react-native-medi/src/__tests__/index.test.tsx

packages/react-native-medi/ios/Medi.h

packages/react-native-medi/android/src/main/java/com/medi/MediModule.kt

mdydek · 2025-12-05T09:58:29Z

apps/medi-expo-example/.gitignore

since midi package is not planned to be in separate repository, you can use our main .gitignore

don't get it? You can nest .gitignores it is auto generated from expo project it has some expo specific things i guess

mdydek · 2025-12-05T10:21:16Z

packages/react-native-medi/ios/Medi.mm

+#ifdef RCT_NEW_ARCH_ENABLED
+- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
+    (const facebook::react::ObjCTurboModule::InitParams &)params
+{
+  return std::make_shared<facebook::react::NativeMediSpecJSI>(params);
+}
+#endif


if it doesn't support old arch, why this check

mdydek · 2025-12-05T10:28:33Z

packages/react-native-medi/Medi.podspec

+package = JSON.parse(File.read(File.join(__dir__, "package.json")))
+
+Pod::Spec.new do |s|
+  s.name         = "Medi"


Suggested change

s.name = "Medi"

s.name = "RNOurAgreedName"

mdydek · 2025-12-05T10:30:53Z

packages/react-native-medi/ios/Medi.mm

+  ///
+  /// PS: Not actually wasted time cuz it works but brooo☠
+  dispatch_async(dispatch_get_main_queue(), ^{
+    OSStatus status = MIDIClientCreateWithBlock(CFSTR("MediClient"), &_midiClient, ^(const MIDINotification *message) {


Suggested change

OSStatus status = MIDIClientCreateWithBlock(CFSTR("MediClient"), &_midiClient, ^(const MIDINotification *message) {

OSStatus status = MIDIClientCreateWithBlock(CFSTR("MediClient"), &self->_midiClient, ^(const MIDINotification *message) {

mdydek · 2025-12-05T10:31:21Z

packages/react-native-medi/ios/Medi.mm

+
+    self.sysexEnabled = sysex;
+    NSLog(@"MIDIClientCreateWithBlock status: %d, sysex: %d", status, sysex);
+    OSStatus statusPort = MIDIInputPortCreateWithProtocol(self.midiClient, CFSTR("MediInputPort"), kMIDIProtocol_1_0, &_inputPort, ^(const MIDIEventList *eventList, void *srcConnRefCon) {


Suggested change

OSStatus statusPort = MIDIInputPortCreateWithProtocol(self.midiClient, CFSTR("MediInputPort"), kMIDIProtocol_1_0, &_inputPort, ^(const MIDIEventList *eventList, void *srcConnRefCon) {

OSStatus statusPort = MIDIInputPortCreateWithProtocol(self.midiClient, CFSTR("MediInputPort"), kMIDIProtocol_1_0, &self->_inputPort, ^(const MIDIEventList *eventList, void *srcConnRefCon) {

mdydek · 2025-12-05T10:35:05Z

packages/react-native-medi/ios/Medi.mm

+                  reject:(RCTPromiseRejectBlock)reject)
+{
+  if (self.midiClient != 0) {
+    resolve(nil);


resolve promises with better info

mdydek · 2025-12-05T10:35:53Z

packages/react-native-medi/ios/Medi.mm

+    NSLog(@"MIDIInputPortCreateWithProtocol status: %d", statusPort);
+
+    // Resolve the promise after MIDI client is fully initialized
+    resolve(nil);


resolve promises with better info

mdydek · 2025-12-05T10:41:03Z

packages/react-native-medi/ios/Medi.mm

+RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(NSNumber *, openPort:(NSString *)portId)
+{
+  NSString *type = [portId hasPrefix:@"input_"] ? @"input" : @"output";
+  SInt32 uniqueID = [[portId substringFromIndex:[type length] + 1] intValue];
+  if ([type isEqualToString:@"output"]) {
+    // We do not need to open output ports so it is considered always successful
+    NSLog(@"Opened output port: %@", portId);
+    return @YES;
+  }
+  MIDIEndpointRef endpoint = 0;
+  ItemCount srcCount = MIDIGetNumberOfSources();
+  for (ItemCount i = 0; i < srcCount; ++i) {
+    MIDIEndpointRef src = MIDIGetSource(i);
+    SInt32 srcUniqueID = 0;
+    MIDIObjectGetIntegerProperty(src, kMIDIPropertyUniqueID, &srcUniqueID);
+    if (srcUniqueID == uniqueID) {
+      endpoint = src;
+      break;
+    }
+  }
+  if (endpoint == 0) {
+    NSLog(@"Port not found: %@", portId);
+    return @NO;
+  }
+
+  OSStatus status = MIDIPortConnectSource(self.inputPort, endpoint, (void *)(uintptr_t)endpoint);
+  if (status != noErr) {
+    NSLog(@"Failed to connect input port: %@, status: %d", portId, status);
+    return @NO;
+  }
+
+  self.openPorts[portId] = @(endpoint);
+  NSLog(@"Opened port: %@", portId);
+  return @YES;
+}


Suggested change

RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(NSNumber *, openPort:(NSString *)portId)

{

NSString *type = [portId hasPrefix:@"input_"] ? @"input" : @"output";

SInt32 uniqueID = [[portId substringFromIndex:[type length] + 1] intValue];

if ([type isEqualToString:@"output"]) {

// We do not need to open output ports so it is considered always successful

NSLog(@"Opened output port: %@", portId);

return @YES;

}

MIDIEndpointRef endpoint = 0;

ItemCount srcCount = MIDIGetNumberOfSources();

for (ItemCount i = 0; i < srcCount; ++i) {

MIDIEndpointRef src = MIDIGetSource(i);

SInt32 srcUniqueID = 0;

MIDIObjectGetIntegerProperty(src, kMIDIPropertyUniqueID, &srcUniqueID);

if (srcUniqueID == uniqueID) {

endpoint = src;

break;

}

}

if (endpoint == 0) {

NSLog(@"Port not found: %@", portId);

return @NO;

}

OSStatus status = MIDIPortConnectSource(self.inputPort, endpoint, (void *)(uintptr_t)endpoint);

if (status != noErr) {

NSLog(@"Failed to connect input port: %@, status: %d", portId, status);

return @NO;

}

self.openPorts[portId] = @(endpoint);

NSLog(@"Opened port: %@", portId);

return @YES;

}

RCT_EXPORT_SYNCHRONOUS_TYPED_METHOD(BOOL, openPort:(NSString *)portId)

{

NSString *type = [portId hasPrefix:@"input_"] ? @"input" : @"output";

SInt32 uniqueID = [[portId substringFromIndex:[type length] + 1] intValue];

if ([type isEqualToString:@"output"]) {

// We do not need to open output ports so it is considered always successful

NSLog(@"Opened output port: %@", portId);

return YES;

}

MIDIEndpointRef endpoint = 0;

ItemCount srcCount = MIDIGetNumberOfSources();

for (ItemCount i = 0; i < srcCount; ++i) {

MIDIEndpointRef src = MIDIGetSource(i);

SInt32 srcUniqueID = 0;

MIDIObjectGetIntegerProperty(src, kMIDIPropertyUniqueID, &srcUniqueID);

if (srcUniqueID == uniqueID) {

endpoint = src;

break;

}

}

if (endpoint == 0) {

NSLog(@"Port not found: %@", portId);

return NO;

}

OSStatus status = MIDIPortConnectSource(self.inputPort, endpoint, (void *)(uintptr_t)endpoint);

if (status != noErr) {

NSLog(@"Failed to connect input port: %@, status: %d", portId, status);

return NO;

}

self.openPorts[portId] = @(endpoint);

NSLog(@"Opened port: %@", portId);

return YES;

}

for me it would better map with js equivalent of this function

feat: initialized folder

b904710

poneciak57 self-assigned this Oct 13, 2025

poneciak57 added feature New feature development Develop some feature or integrate it with sth labels Oct 13, 2025

poneciak57 added 16 commits October 13, 2025 07:37

fix: fixed library to work and verified it in fabric example

309b57d

feat: implemented typescript interface

b0c41cf

fix: removed example app

a62fb58

feat: implemented basic native ios module

57a4665

chore: state updt

01d6870

fix: performed devibeification

8ba2e83

feat: implemented simple methods for midi port discovery

5067311

feat: implemented everything besides event emiting

f055ff8

feat: implemented all ios methods

fc1b6ea

feat: implemented all android methods

1ad7e28

feat: implemented ts layer

dc78ae3

fix: made midi initialization async

27243c9

fix: proper packed message handling

bb28e43

feat: enchanced midi example

e55215b

feat: example expo app for midi

7cca34a

feat: web support

7bdc687

poneciak57 marked this pull request as ready for review December 1, 2025 12:46

poneciak57 requested review from maciejmakowski2003, mdydek and michalsek December 1, 2025 12:46

poneciak57 changed the title ~~feat: support for midi~~ feat: support for midi 0.1 Dec 1, 2025

maciejmakowski2003 requested changes Dec 2, 2025

View reviewed changes

poneciak57 added 4 commits December 3, 2025 10:20

fix: requested changes

70c849a

Merge branch 'main' into feat/react-native-medi

27e61d5

chore: neatpicks

5589dd6

docs: added readme

e28042b

mdydek requested changes Dec 5, 2025

View reviewed changes

	OSStatus status = MIDIClientCreateWithBlock(CFSTR("MediClient"), &_midiClient, ^(const MIDINotification *message) {
	OSStatus status = MIDIClientCreateWithBlock(CFSTR("MediClient"), &self->_midiClient, ^(const MIDINotification *message) {

	OSStatus statusPort = MIDIInputPortCreateWithProtocol(self.midiClient, CFSTR("MediInputPort"), kMIDIProtocol_1_0, &_inputPort, ^(const MIDIEventList eventList, void srcConnRefCon) {
	OSStatus statusPort = MIDIInputPortCreateWithProtocol(self.midiClient, CFSTR("MediInputPort"), kMIDIProtocol_1_0, &self->_inputPort, ^(const MIDIEventList eventList, void srcConnRefCon) {

Uh oh!

feat: support for midi 0.1 #736

Are you sure you want to change the base?

feat: support for midi 0.1 #736

Uh oh!

Conversation

poneciak57 commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

poneciak57 commented Oct 13, 2025 •

edited

Loading